34603[BUGFIX] Add missing htmlspecialchars() or quoteJSvalue()
Commit message
Review
-
Code review CR +2
- Helmut Hummel +2
- Mathias Schreiber +1
- Markus Klein +1
-
Verified V +2
- Markus Klein +2
- Mathias Schreiber +1
Issues 1
Files 8
- typo3/sysext/backend/Classes/Controller/File/CreateFolderController.php+1 −1
- typo3/sysext/install/Classes/Report/InstallStatusReport.php+1 −1
- typo3/sysext/recordlist/Classes/RecordList/DatabaseRecordList.php2+14 −14
- typo3/sysext/reports/Classes/Report/Status/ConfigurationStatus.php+1 −1
- typo3/sysext/reports/Classes/Report/Status/SecurityStatus.php+2 −2
- typo3/sysext/setup/Classes/Controller/SetupModuleController.php+1 −1
- typo3/sysext/sys_action/Classes/ActionTask.php+4 −3
- typo3/sysext/version/Classes/Controller/VersionModuleController.php+1 −1
Review log 11
-
Stefan Neufeind uploaded patch set 1 11/25/14, 12:59
-
Stefan Neufeind commented on patch set 1 11/25/14, 13:01
Searched for getModuleUrl() near href=. There might still be other occurences left.done against master, I guess (mostly) for 6.2 as well, can't say about other branches yet -
Stefan Neufeind commented on patch set 1 11/25/14, 13:06
DatabaseRecordList.php:1194it wasn't really "missing" here. But added it to the link-creation to be more consistent and removed it above where the URL/onClick is constructed. Currently it was done once in the link and once in the variable - makes checking for consistency harder.DatabaseRecordList.php:1229remove the opening brace as well, of course -
Markus Klein commented on patch set 1 11/25/14, 15:56
Why does this patch have a "connot merge"? can you update it for current master? -
Stefan Neufeind uploaded patch set 2 11/25/14, 16:19
-
Stefan Neufeind commented on patch set 2 11/25/14, 16:21
"cannot merge" was because the other follow-up that got merged conflicteddone against master, I guess (mostly) for 6.2 as well, can't say about other branches yet -
Markus Klein voted on patch set 2 CR +1 V +1 11/26/14, 13:08
-
Mathias Schreiber voted on patch set 2 CR +1 V +1 11/26/14, 14:05
-
Helmut Hummel commented on patch set 2 CR +2 11/26/14, 20:53
great cleanup! Thanks a lot. -
Markus Klein voted on patch set 2 V +2 11/28/14, 11:27
-
Markus Klein merged patch set 2 11/28/14, 11:27