Review main Merged

34639[BUGFIX] Follow up: Use strrpos to find last occurence

Andreas Kienast CR +2 V +2 Easy +25 −1 updated 11/27/14, 10:31

Commit message

The patch #61654 introduced a bug, where strpos is mistakenly
used to get the last position of the currently processed field.
It must be changed to strrpos, otherwise the opening brace
breaks the SQL.

Also, a unit test for this case is added.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 2

Files 2