34740[BUGFIX] Add missing htmlspecialchars() or quoteJSvalue()
Commit message
Review
-
Code review CR +2
- Markus Klein +2
-
Verified V +2
- Markus Klein +2
Issues 1
Files 7
- typo3/sysext/install/Classes/Report/InstallStatusReport.php+1 −1
- typo3/sysext/recordlist/Classes/RecordList/DatabaseRecordList.php+2 −4
- typo3/sysext/reports/Classes/Report/Status/ConfigurationStatus.php+1 −1
- typo3/sysext/reports/Classes/Report/Status/SecurityStatus.php+2 −2
- typo3/sysext/setup/Classes/Controller/SetupModuleController.php2+2 −2
- typo3/sysext/sys_action/Classes/ActionTask.php+4 −3
- typo3/sysext/version/Classes/Controller/VersionModuleController.php+1 −1
Review log 7
-
Markus Klein uploaded patch set 1 11/28/14, 11:37
-
Markus Klein commented on patch set 1 11/28/14, 11:39
@Stefan: Please double check if I didn't miss anything on the manual backport. Thanks -
Stefan Neufeind commented on patch set 1 CR -1 11/28/14, 11:52
Looks good, except one case. Rest should be fine imho. Thanks a lot for the backport.SetupModuleController.php:653You must not remove this window.location.href here. See in master at: https://review.typo3.org/#/c/34603/3/typo3/sysext/setup/Classes/Controller/SetupModuleController.php -
Markus Klein commented on patch set 1 11/28/14, 13:00
SetupModuleController.php:653ReplyIt's not removed. check again please. ;-) -
Markus Klein rebased onto patch set 1 11/30/14, 23:28
-
Markus Klein voted on patch set 2 CR +2 V +2 11/30/14, 23:29
-
Markus Klein merged patch set 2 11/30/14, 23:29