Review TYPO3_6-2 Merged

34740[BUGFIX] Add missing htmlspecialchars() or quoteJSvalue()

Markus Klein CR +2 V +2 Easy +13 −14 updated 11/30/14, 23:29

Commit message

Review

  • Code review CR +2
    • Markus Klein +2
  • Verified V +2
    • Markus Klein +2

Issues 1

Files 7

Review log 7

  1. Markus Klein uploaded patch set 1 11/28/14, 11:37

  2. Markus Klein commented on patch set 1 11/28/14, 11:39

    @Stefan: Please double check if I didn't miss anything on the manual backport. Thanks
  3. Stefan Neufeind commented on patch set 1 CR -1 11/28/14, 11:52

    Looks good, except one case. Rest should be fine imho. Thanks a lot for the backport.

    SetupModuleController.php:653

    You must not remove this window.location.href here. See in master at: https://review.typo3.org/#/c/34603/3/typo3/sysext/setup/Classes/Controller/SetupModuleController.php
  4. Markus Klein commented on patch set 1 11/28/14, 13:00

    SetupModuleController.php:653 Reply

    It's not removed. check again please. ;-)
  5. Markus Klein rebased onto patch set 1 11/30/14, 23:28

  6. Markus Klein voted on patch set 2 CR +2 V +2 11/30/14, 23:29

  7. Markus Klein merged patch set 2 11/30/14, 23:29