Review main Merged

34785[BUGFIX] Fix questionable SQL schema definition for sys_file

Mathias Schreiber CR +2 V +2 Easy +6 −6 updated 11/30/14, 10:11

Commit message

Shorten field size for SHA1 (which is always 40 characters)
Remove index alias for sys_file.sha1

Review

  • Code review CR +2
    • Xavier Perseguers +2
    • Christian Kuhn +1
  • Verified V +2
    • Xavier Perseguers +2
    • Christian Kuhn +1

Issues 1

Files 1

Review log 6

  1. Mathias Schreiber uploaded patch set 1 11/29/14, 23:08

  2. Mathias Schreiber uploaded patch set 2 11/29/14, 23:20

  3. Mathias Schreiber uploaded patch set 3 11/29/14, 23:25

  4. Christian Kuhn commented on patch set 3 CR +1 V +1 11/30/14, 00:27

    This looks good from reading: varchar(40) to char(40) is ok (?!!!) as well as the key change. DB compare in install tool copes fine with the changes, too. Looks good from my side.
  5. Xavier Perseguers voted on patch set 3 CR +2 V +2 11/30/14, 10:11

  6. Xavier Perseguers merged patch set 3 11/30/14, 10:11