35006[TASK] Add configuration file for DynamicReturnTypePlugin
Commit message
Review
-
Code review CR +2
- Jigal van Hemert +2
-
Verified V +2
- Jigal van Hemert +2
Issues 1
Files 1
Review log 22
-
Frank Nägler uploaded patch set 1 12/03/14, 19:39
-
Mathias Schreiber voted on patch set 1 CR +1 V +1 12/03/14, 19:44
-
Jigal van Hemert commented on patch set 1 CR +1 V +1 12/03/14, 19:58
Works even if you use the core as Resource Root in a project. -
Frank Nägler commented on patch set 1 12/03/14, 20:29
@jigal, did you mean the configuration file is not needed? -
Ingo Renner commented on patch set 1 CR +1 V +1 12/03/14, 21:24
I'm using that in all my projects, having it in the core would be awesome and save a couple seconds :) -
Jigal van Hemert commented on patch set 1 12/03/14, 21:52
> @jigal, did you mean the configuration file is not needed? The configuration file is needed. The plugin says it must be in the root of the project. In most projects of extensions I have the core included "Resource Root". With the configuration file in the core directory it even works in those projects. It saves time and removes a lot of marked errors in the source code for objects without a @var comment. -
Stefan Neufeind commented on patch set 1 12/05/14, 19:12
Sounds like a good idea. But I'm unsure whether we should really clutter the root-directory with more and more files :-( -
Stefan Neufeind voted on patch set 1 V +1 12/05/14, 19:23
-
Stefan Neufeind voted on patch set 1 CR +1 12/05/14, 19:23
-
Jigal van Hemert commented on patch set 1 12/05/14, 19:52
> Sounds like a good idea. But I'm unsure whether we should really > clutter the root-directory with more and more files :-( We could remove some of the others? I have no use for most of the others that are currently there. -
Markus Klein commented on patch set 1 CR -1 12/06/14, 01:28
dynamicReturnTypeMeta.json:13getMock and getAccessibleMock is missing -
Markus Klein voted on patch set 1 CR 0 12/06/14, 01:28
-
Frank Nägler commented on patch set 1 12/06/14, 10:15
dynamicReturnTypeMeta.json:13Replyworks without configuration in my installation, strange. Any idea why it works for me? -
Markus Klein commented on patch set 1 12/06/14, 13:46
dynamicReturnTypeMeta.json:13Replymaybe because we already have so many typehint comments in the unit tests? Generally we will still need them, as getAccessibleMock returns actually 3 types: AccessibleInterface, PHP___MockObject and the class itself -
Frank Nägler commented on patch set 1 12/06/14, 13:53
dynamicReturnTypeMeta.json:13ReplyI have tested a lot of getMock methods and get evertime the concret type back. Not sure why, this is strange. I have not configured the methods, but in this cases PHPStorm knows the return type. :/ -
Frank Nägler uploaded patch set 2 12/06/14, 22:59
-
Markus Klein voted on patch set 2 CR +1 12/06/14, 23:03
-
Oliver Klee voted on patch set 2 CR +1 12/06/14, 23:05
-
Stefan Neufeind commented on patch set 2 CR +1 V +1 12/06/14, 23:21
It looks like you just added the comment? I have some nitpicks, but still reapply my previous vote here.dynamicReturnTypeMeta.json:5better maybe: type-information gets lost. use phpdoc-comments to define object-types -
Jigal van Hemert uploaded patch set 3 12/06/14, 23:55
-
Jigal van Hemert commented on patch set 3 CR +2 V +2 12/06/14, 23:55
Only comments changed in last set, so votes can be kept. -
Jigal van Hemert merged patch set 3 12/06/14, 23:56