35019[FOLLOWUP][BUGFIX] objectManager->create is removed but still in use
Commit message
Review
-
Code review CR +2
- Markus Klein +2
-
Verified V +2
- Markus Klein +2
Issues 1
Files 2
Review log 8
-
Stefan Neufeind uploaded patch set 1 12/04/14, 01:21
-
Stefan Neufeind commented on patch set 1 12/04/14, 01:22
Not really critical, but for 6.2 there are two more occurences in functional API. (They don't exist like this in master anymore.) -
Markus Klein commented on patch set 1 CR -1 12/04/14, 01:42
are you sure about master? -
Stefan Neufeind commented on patch set 1 12/04/14, 01:47
Reply
The original patch, to which this is a followup, was for master as well. Imho we had similar cases in the past: We kept title, Releases etc. unchanged but adjusted the fix where needed upon backport. That's what I see here as well. -
Markus Klein updated the commit message in patch set 2 12/04/14, 01:51
-
Markus Klein voted on patch set 2 CR +1 V +1 12/04/14, 01:52
-
Markus Klein voted on patch set 2 CR +2 V +2 12/04/14, 01:53
-
Markus Klein merged patch set 2 12/04/14, 01:53