Review main Abandoned

35100[TASK] Allow spaces in usernames

Stefan Neufeind CR 0 V 0 Easy +2 −2 updated 12/06/14, 12:29

Commit message

Usernames like "Firstname Lastname" are no problem at login,
but currently the backend removes spaces from FE-/BE-users.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 2

Review log 4

  1. Stefan Neufeind uploaded patch set 1 12/06/14, 11:43

  2. Torben Hansen voted on patch set 1 CR +1 V +1 12/06/14, 11:57

  3. Helmut Hummel commented on patch set 1 CR -1 12/06/14, 12:27

    Changing this just because we can? I don't see strong reasons for this change and I fear that this will bite us in the future.
  4. Stefan Neufeind abandoned the change 12/06/14, 12:29

    This might cause trouble. One example might be usernames with one or two spaces inbetween which look "almost lookalike" (or in HTML even might appear identically).