Review main Abandoned

35119[TASK] Show info msg in functions module if no wizard selected

Georg Ringer CR 0 V 0 Easy +11 −0 updated 12/16/14, 06:11

Commit message

If no wizard is selected in the functions module, show an info
message instead of a blank content area.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 2

Review log 6

  1. Georg Ringer uploaded patch set 1 12/06/14, 21:31

  2. Stefan Neufeind commented on patch set 1 CR +1 12/06/14, 21:36

    Looks okay at first sight.

    locallang_mod_web_func.xlf:22

    I'm unsure whether it might need to be "from the menu" instead. But we have one other "in the list" in our current xlf-files.
  3. Stefan Neufeind commented on patch set 1 V +1 12/07/14, 15:40

    We also discussed that in other modules (like "Reports") there is an overview-page explaining the modules. Something like that might be a good idea for the wizards as well. @Georg: Could you add that as a separate issue for enhancement maybe? For the moment I'd be fine with the change here.
  4. Benni Mack commented on patch set 1 CR -2 12/13/14, 13:19

    please read what your code does. It checks on the version selector!
  5. Benni Mack voted on patch set 1 CR -1 12/13/14, 13:19

  6. Georg Ringer abandoned the change 12/16/14, 06:11

    no overview anymore in master...