Review main Merged Breaking

35315[!!!][TASK] Replace DataHandler->exclude_array with key-based array

Stephan Großberndt CR +2 V +2 Easy +38 −5 updated 03/11/15, 18:47

Commit message

Replace the public property array 'exclude_array' in DataHandler with a
protected property 'excludedTablesAndFields' using keys instead of
values. This change improves performance for bulk inserts since in
DataHandler->fillInFieldArray() many in_array()-checks can be avoided.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 2