35600[BUGFIX] Properly HTML encode URI in renderer
Commit message
Review
-
Code review CR +2
- Wouter Wolters +2
- Roman Schürmann +1
- Mathias Schreiber +1
-
Verified V +2
- Wouter Wolters +2
- Roman Schürmann +1
- Mathias Schreiber +1
Issues 1
Files 4
Review log 7
-
Helmut Hummel uploaded patch set 1 12/20/14, 14:01
-
Mathias Schreiber voted on patch set 1 CR +1 V +1 12/20/14, 14:12
-
Roman Schürmann voted on patch set 1 CR +1 V +1 12/20/14, 14:53
-
Wouter Wolters voted on patch set 1 V +2 CR +2 12/20/14, 14:56
-
Wouter Wolters merged patch set 1 12/20/14, 14:56
-
Frans Saris commented on patch set 2 12/20/14, 15:49
Isn't the url already encoded by the file driver? -
Helmut Hummel commented on patch set 2 12/20/14, 18:10
@Frans: Why should the driver HTML encode the URI? That would not make any sense, as you could not use it e.g. in JavaScript or HTTP Header context any more. It must be HTML encoded if used in HTML context (like here) or Json encoded if used as JavaScript value (aka GeneralUtility::quoteJSValue) and so on