Review main Merged

35753[BUGFIX] Page View Button misses tooltip in page language module

Anja Leichsenring CR +2 V +2 Easy +1 −1 updated 01/03/15, 13:55

Commit message

Add a title attribute to the view page button in page module,
when language mode is active.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Mathias Schreiber +1
  • Verified V +2
    • Wouter Wolters +2
    • Mathias Schreiber +1

Issues 1

Files 1

Review log 12

  1. Anja Leichsenring uploaded patch set 1 01/03/15, 12:29

  2. Mathias Schreiber voted on patch set 1 CR +1 V +1 01/03/15, 12:32

  3. Anja Leichsenring wrote 01/03/15, 13:01

    Topic set to Backend
  4. Wouter Wolters commented on patch set 1 CR -2 01/03/15, 13:04

    this delivers broken HTML, on it.
  5. Wouter Wolters commented on patch set 1 01/03/15, 13:06

    PageLayoutView.php:671

    " before title is wrong Use getLanguageService() instead of $GLOBALS
  6. Wouter Wolters uploaded patch set 2 01/03/15, 13:06

  7. Wouter Wolters voted on patch set 2 V +1 CR +1 01/03/15, 13:07

  8. Anja Leichsenring commented on patch set 2 01/03/15, 13:07

    copy & paste -.- Thanks Wouter!
  9. Mathias Schreiber voted on patch set 2 CR +1 V +1 01/03/15, 13:51

  10. Wouter Wolters voted on patch set 2 V +2 CR +2 01/03/15, 13:54

  11. Wouter Wolters merged patch set 2 01/03/15, 13:54

  12. Wouter Wolters commented on patch set 3 01/03/15, 13:55

    Cherry Picked This patchset was cherry picked to branch TYPO3_6-2 as commit 06f3842b0e37d770a6696486fa9e61ce65da657b