35947[BUGFIX] Pagepath is displayed incorrectly with slash (/) in page title
Commit message
Review
-
Code review CR +2
- Markus Klein +2
- Daniel Maier +1
-
Verified V +2
- Markus Klein +2
- Daniel Maier +1
Issues 1
Files 1
Review log 12
-
Benni Mack uploaded patch set 1 01/10/15, 19:17
-
Tymoteusz Motylewski voted on patch set 1 CR +1 V +1 01/10/15, 20:41
-
Daniel Maier voted on patch set 1 CR +1 V +1 01/10/15, 21:10
-
Markus Klein commented on patch set 1 CR -1 01/10/15, 22:03
-
Markus Klein commented on patch set 1 01/10/15, 22:04
A classical candidate for a unit test btw -
Daniel Maier commented on patch set 1 CR 0 V 0 01/11/15, 13:02
DocumentTemplate.php:1903ReplyI think that $pageRecord['_thePathFull'] always starts with a leading slash. So counting the leading slash $pos won't be 0 anyway. Or am I wrong here? Other question would be, why first cutting off the last character (IMO the trailing /) here by the $pos-1-length, and then adding it again right after that. What about just using $title = substr($title, 0, $pos)? -
Markus Klein uploaded patch set 2 01/13/15, 23:00
-
Markus Klein voted on patch set 2 CR +1 V +1 01/13/15, 23:00
-
Daniel Maier voted on patch set 2 CR +1 V +1 01/13/15, 23:00
-
Markus Klein voted on patch set 2 CR +2 V +2 01/13/15, 23:00
-
Markus Klein merged patch set 2 01/13/15, 23:00
-
Markus Klein commented on patch set 3 01/13/15, 23:00
Cherry Picked This patchset was cherry picked to branch TYPO3_6-2 as commit 7760042416bcafbeac2b1e15a32d8d3c0935775b
DocumentTemplate.php:1903