Review main Merged

36055[TASK] Make array utility test do not depend on undefined behaviour

Tymoteusz Motylewski CR +2 V +2 Easy +25 −25 updated 01/17/15, 12:30

Commit message

ArrayUtilityTests expect that order of elements with the same value
will not change. PHP doesn't guarantee that, so it doesn't make
sense to test this behaviour.

This test fails under HHVM which has different sorting
implementation than PHP 5.

Actually PHP 7 is going into the same direction, so sooner
or later this test will fail also under PHP.
See https://github.com/php/php-src/pull/999
and https://github.com/facebook/hhvm/issues/4649

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 1