Review main Abandoned

36128[BUGFIX] makeShortcutIcon() fails parse_url with REQUEST_URI

Wouter Wolters CR 0 V 0 Easy +1 −1 updated 01/19/15, 23:03

Commit message

This fails because parse_url only works with urls and not with uris.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 7

  1. Wouter Wolters uploaded patch set 1 01/19/15, 22:35

  2. Mathias Schreiber updated the commit message in patch set 2 01/19/15, 22:37

  3. Mathias Schreiber voted on patch set 2 CR +1 V +1 01/19/15, 22:38

  4. Helmut Hummel commented on patch set 2 CR -1 01/19/15, 22:56

    on it
  5. Helmut Hummel voted on patch set 2 V -1 01/19/15, 22:58

  6. Helmut Hummel commented on patch set 2 01/19/15, 23:00

    DocumentTemplate.php:622

    There is no REQUEST_URL! Either REQUEST_URI or TYPO3_REQUEST_URL Since I can't find a bug here, I trend to abandon this one and close the bug as fixed on forge
  7. Wouter Wolters abandoned the change 01/19/15, 23:03