Review main Merged

36246[TASK] Refactor ext:beuser access module

Christian Kuhn CR +2 V +2 Hard +440 −164 updated 01/25/15, 20:49

Commit message

* Move most rendering from PermissionController and
  PermissionAjaxController to fluid
* PermissionController no longer calls methods from
  PermissionAjaxController
* PermissionController no longer loops over the result
  set of getTree() in indexAction to prepare view data
* Fix a couple of minor edge cases and bugs, especially
  some missing labels
* Deprecate some now unused public methods in
  PermissionAjaxController

Even with additional fluid rendering, the module is about
20% quicker with applied patch rendering longish tree lists,
mostly by suppressing tons of calls to the sprite icon API.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 12