Review main Merged

36286[TASK] Add CompilableInterface to a couple of view helpers

Christian Kuhn CR +2 V +2 Hard +234 −68 updated 01/28/15, 16:33

Commit message

This patch changes a couple of view helpers that can easily
implement CompilableInterface to supress object creating at
render time.

TranslateViewHelper is especially interesting since this
one is used very often.

CommentViewHelper additionally overwrites compile() so
child nodes (the comments) are not evaluated at all.

All these view helpers are used in be_user access module
and lead to a speed up from roughly 7 to 5 seconds for
a list of 900 pages on my testsystem, now creating "only"
14 thousand objects instead of 21 thousand.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 10