Review main Merged

36375[BUGFIX] Proper error handling of ResourceDoesNotExistException

Ruud Silvrants CR +2 V +2 Easy +21 −1 updated 01/30/15, 12:37

Commit message

Handles and displaying a proper error message when
ResourceDoesNotExistException is thrown.

Review

  • Code review CR +2
    • Frans Saris +2
    • Wouter Wolters +1
    • Christian Weiske +1
    • Michael Oehlhof +1
  • Verified V +2
    • Frans Saris +2
    • Christian Weiske +1

Issues 1

Files 2

Review log 12

  1. Ruud Silvrants uploaded patch set 1 01/29/15, 17:44

  2. Ruud Silvrants updated the commit message in patch set 2 01/29/15, 17:49

  3. Philipp Gampe commented on patch set 2 01/29/15, 22:03

    going to push an update

    ExtendedFileUtility.php:336

    CGL, no spaces inside the brackets
  4. Philipp Gampe uploaded patch set 3 01/29/15, 22:06

  5. Philipp Gampe voted on patch set 3 CR +1 V +1 01/29/15, 22:06

  6. Wouter Wolters updated the commit message in patch set 4 01/29/15, 22:59

  7. Wouter Wolters voted on patch set 4 CR +1 01/29/15, 22:59

  8. Christian Weiske commented on patch set 4 CR +1 V +1 01/30/15, 11:06

    Works fine.
  9. Frans Saris voted on patch set 4 CR +1 01/30/15, 12:22

  10. Michael Oehlhof voted on patch set 4 CR +1 01/30/15, 12:23

  11. Frans Saris voted on patch set 4 CR +2 V +2 01/30/15, 12:37

  12. Frans Saris merged patch set 4 01/30/15, 12:37