Review main Merged

36472[FEATURE] Display the bad class name in makeInstance

Oliver Klee CR +2 V +2 Easy +7 −3 updated 01/30/15, 21:38

Commit message

The class name provided to GeneralUtility::makeInstance must not
start with a backslash. To help track down the offending code parts,
makeInstance now includes the offending class name in the exception
message.

Review

  • Code review CR +2
    • Benni Mack +2
    • Christian Kuhn +1
  • Verified V +2
    • Benni Mack +2
    • Christian Kuhn +1

Issues 1

Files 1

Review log 9

  1. Oliver Klee uploaded patch set 1 01/30/15, 19:55

  2. Oliver Klee commented on patch set 1 01/30/15, 19:57

    How to test: Run the current (erroring) unit tests of the phpunit extension in the BE module and have a look at the error messages. :-)
  3. Stefan Froemken commented on patch set 1 01/30/15, 20:42

    GeneralUtility.php:4344

    delete empty line

    GeneralUtility.php:4346

    here, too
  4. Benni Mack commented on patch set 1 01/30/15, 20:42

    Should we do a HSC?
  5. Oliver Klee commented on patch set 1 01/30/15, 21:34

    No, not for the exception message. The correct place for hsc is just before the output in the corresponding context, i.e., when including it on a page. That is part of the error handler, not of the code throwing an exception.
  6. Oliver Klee commented on patch set 1 01/30/15, 21:35

    GeneralUtility.php:4344 Reply

    I added the lines to have more visual separation between the annotation types. Do we have something in the CGL about whether to have empty lines there?
  7. Christian Kuhn voted on patch set 1 CR +1 V +1 01/30/15, 21:37

  8. Benni Mack commented on patch set 1 CR +2 V +2 01/30/15, 21:38

    GREAT stuff!
  9. Benni Mack merged patch set 1 01/30/15, 21:38