Review main Merged

36491[BUGFIX] Improve functional test execution on Windows system

Nicole Hummel CR +2 V +2 Easy +8 −7 updated 01/31/15, 15:11

Commit message

On Windows systems you can execute several commands using '&' like
set typo3DatabaseUsername=root & set typo3DatabasePassword=root.
Unfortunately Windows sets those parameter with a trailing space. This
causes database connections not to work. Therefore the patch adds a trim
on getting system environment variables for database credentials for
functional tests.

Furthermore the PHP versions on Windows throw a warning on setting the
database name when the connection is closed. The warning is caught by
PHPUnit but the database tables aren't initialized correctly. This patch
adds an '@' to mute the warning.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 1