Review main Abandoned

36504[FEATURE] Add real-world example to the FileStreamWrapperTest

Philipp Gampe CR 0 V 0 Easy +19 −1 updated 01/31/15, 17:01

Commit message

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 3

  1. Philipp Gampe uploaded patch set 1 01/31/15, 13:53

  2. Oliver Klee commented on patch set 1 01/31/15, 16:31

    FileStreamWrapperTest.php:62

    Actually, it looks like these should be 2 tests: one for the overlay and one for recursively creating directories. Then the names will get shorter, too.

    FileStreamWrapperTest.php:65

    Most certainly this should be "must" instead of "most". :-)
  3. Philipp Gampe abandoned the change 01/31/15, 17:01

    I don't want to have the dependency to GeneralUtility in this test. This was mainly an example for other participants at this code sprint (Essen).