Review main Merged

37018[TASK] Streamline layout of "New file or folder wizard"

Andreas Kienast CR +2 V +2 Normal +51 −24 updated 02/19/15, 21:16

Commit message

Update the forms to the new layout used in the backend. Remove the
redundant "Cancel" buttons, as the same action is in the top bar
already.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Michael Oehlhof +1
    • Benjamin Kott +1
  • Verified V +2
    • Wouter Wolters +2
    • Michael Oehlhof +1
    • Benjamin Kott +1

Issues 1

Files 2

Review log 13

  1. Andreas Kienast uploaded patch set 1 02/19/15, 11:52

  2. Andreas Kienast uploaded patch set 2 02/19/15, 13:18

  3. Andreas Kienast uploaded patch set 3 02/19/15, 13:33

  4. Benjamin Kott voted on patch set 3 CR +1 V +1 02/19/15, 13:37

  5. Frans Saris commented on patch set 3 02/19/15, 13:40

    CreateFolderController.php:186

    Why did you remove the different button styling?
  6. Andreas Kienast commented on patch set 3 02/19/15, 13:42

    CreateFolderController.php:186 Reply

    Until now, all buttons are "default", this was on of the rare cases were it was colored.
  7. Andreas Kienast commented on patch set 3 02/19/15, 13:51

    CreateFolderController.php:186 Reply

    I just talked to Benji, we will discuss the further styling of buttons at T3UXW.
  8. Andreas Kienast uploaded patch set 4 02/19/15, 13:53

  9. Benjamin Kott commented on patch set 4 02/19/15, 13:59

    we need to have a look at all the views in the backend and have a talk about discussion about how we highlight different actions and need to define primary actions that we want to highlight to provide a visual help for the user. just coloring all the buttons is counterproductive. for me its fine that we remove the coloring here for the moment to get a visual streamlined backend.
  10. Benjamin Kott voted on patch set 4 CR +1 V +1 02/19/15, 14:00

  11. Michael Oehlhof voted on patch set 4 CR +1 V +1 02/19/15, 20:37

  12. Wouter Wolters voted on patch set 4 V +2 CR +2 02/19/15, 21:16

  13. Wouter Wolters merged patch set 4 02/19/15, 21:16