Review main Merged

37046[TASK] Enable clipboard by default

Andreas Kienast CR +2 V +2 Easy +4 −0 updated 02/22/15, 22:17

Commit message

The clipboard is enabled by default now, which displays the copy /
cut / paste actions.

Review

  • Code review CR +2
    • Jigal van Hemert +2
    • Mathias Schreiber +1
    • Benjamin Kott +1
    • Michael Oehlhof +1
    • Nicole Hummel +1
  • Verified V +2
    • Jigal van Hemert +2
    • Mathias Schreiber +1
    • Benjamin Kott +1
    • Michael Oehlhof +1

Issues 1

Files 1

Review log 16

  1. Andreas Kienast uploaded patch set 1 02/20/15, 13:52

  2. Sascha Egerer commented on patch set 1 02/20/15, 14:04

    RecordList.php:283

    I'm not sure where these arrays are composed but wouldn't that change prevent you from deactivating the clipboard if the $this->MO D_SETTINGS['clipBoard'] are not set?
  3. Andreas Kienast commented on patch set 1 V -1 02/20/15, 14:20

    RecordList.php:283 Reply

    Of course, pushing a new patch
  4. Andreas Kienast uploaded patch set 2 02/20/15, 14:25

  5. Sascha Egerer commented on patch set 2 CR -1 02/20/15, 14:35

    RecordList.php:289

    Again I've not checked the logic here but for me these conditions look a little bit useless. Wouldn't it make sense to set "$this->MOD_SETTINGS['clipBoard'] = TRUE;" on line 281 which would be the default then? That will be overwritten if $this->modTSconfig['properties']['enableClipBoard'] is 'deactivated'. The 'activacted' condition can then also be removed. As already said i'm not sure if this would end in any unexpected behavior.
  6. Andreas Kienast commented on patch set 2 02/20/15, 14:39

    RecordList.php:289 Reply

    Well, the else is entered only if enableClipBoard is neither activated not deactivated, which is UserTS. The third state is "selectable" and the default. If you (un)check the checkbox, it's still "selectable", so putting "$this->MOD_SETTINGS['clipBoard'] = TRUE;" on top would break this.
  7. Mathias Schreiber commented on patch set 2 CR +1 V +1 02/20/15, 14:48

    Works as expected. To test: UPDATE be_users SET uc = '' :)
  8. Sascha Egerer voted on patch set 2 CR 0 02/20/15, 14:49

  9. Benjamin Kott voted on patch set 2 CR +1 V +1 02/20/15, 17:34

  10. Michael Oehlhof voted on patch set 2 CR +1 V +1 02/20/15, 21:44

  11. Nicole Hummel commented on patch set 2 CR +1 02/20/15, 21:56

    RecordList.php:289 Reply

    I think this would overwrite a deactivated clip board then.
  12. Michael Oehlhof commented on patch set 2 02/20/15, 22:05

    RecordList.php:289 Reply

    I don't think so. Deactivated clipboard is FALSE. I've CherryPick and for a user with deactivated clipboard it was deactivated. Then I switched to a new user and the clipboard was shown as default.
  13. Nicole Hummel commented on patch set 2 02/20/15, 22:15

    RecordList.php:289 Reply

    @Michael: Sorry, this was the answer for @Sascha ;-)
  14. Jigal van Hemert commented on patch set 2 CR +2 V +2 02/22/15, 20:15

    Already enough votes. Plus: it works :-)
  15. Jigal van Hemert merged patch set 2 02/22/15, 20:15

  16. Philipp Gampe commented on patch set 3 02/22/15, 22:17

    this one misses documentation