Review TYPO3_4-5 Merged

3705[BUGFIX] Error when opening TYPO3 manual

Markus Klein CR +2 V +2 Easy +6 −1 updated 06/03/13, 20:49

Commit message

A missing parameter for SC_view_help::render_Table() causes
TYPO3 manual to produce a PHP warning.
This patch makes the second parameter optional.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Philipp Gampe +1
  • Verified V +2
    • Christian Kuhn +2
    • Philipp Gampe +1

Issues 1

Files 1

Review log 9

  1. Philipp Gampe commented on patch set 1 07/31/11, 15:23

    I just fixed the whitespace error.

    view_help.php:464

    whitespace
  2. Philipp Gampe commented on patch set 1 07/31/11, 15:23

    (1 inline comment) almost ... patch is identical to master
  3. Markus Klein commented on patch set 2 07/31/11, 15:23

    Thanks!
  4. Christian Kuhn commented on patch set 2 V 0 07/31/11, 15:23

    by team member; Looks good to me, approved Same as master version. Merged.
  5. Philipp Gampe uploaded patch set 2 07/31/11, 15:23

  6. Philipp Gampe commented on patch set 2 07/31/11, 15:23

    Verified; Looks good to me, but someone else must approve
  7. Mr. Jenkins commented on patch set 1 07/31/11, 15:23

  8. Mr. Jenkins commented on patch set 2 07/31/11, 15:23

  9. Christian Kuhn merged patch set 2 07/31/11, 15:23