Review main Merged

37205[BUGFIX] Fix faulty negation in FileInfo implementation

Sascha Egerer CR +2 V +2 Easy +2 −2 updated 02/25/15, 12:41

Commit message

A faulty negation in the FileInfo class could end in a fatal
error if `finfo` is not supported by the php version and ends up
in not using `finfo` but `mime_content_type` if `finfo` is
supported.

Review

  • Code review CR +2
    • Markus Klein +2
    • Christian Kuhn +2
    • Wouter Wolters +1
  • Verified V +2
    • Markus Klein +2
    • Christian Kuhn +2

Issues 1

Files 1

Review log 5

  1. Sascha Egerer uploaded patch set 1 02/25/15, 11:48

  2. Markus Klein voted on patch set 1 CR +2 V +2 02/25/15, 11:50

  3. Wouter Wolters voted on patch set 1 CR +1 02/25/15, 12:06

  4. Christian Kuhn voted on patch set 1 CR +2 V +2 02/25/15, 12:40

  5. Christian Kuhn merged patch set 1 02/25/15, 12:41