Review main Merged

37233[TASK] Streamline BE User Initialization with TYPO3_OS

Benni Mack CR +2 V +2 Easy +22 −6 updated 02/25/15, 17:38

Commit message

The BE User initialization in the core uses the TYPO3_OS
constant in various places. The initialization can be
done in the constructor directly. Also, the property
itself ($BE_USER->OS) is not in use directly by the core
and it is encouraged to use the constant directly. The
property is therefore marked for deprecation.

Review

  • Code review CR +2
    • Markus Klein +2
    • Wouter Wolters +1
  • Verified V +2
    • Markus Klein +2
    • Wouter Wolters +1

Issues 1

Files 6

Review log 6

  1. Benni Mack uploaded patch set 1 02/25/15, 16:40

  2. Wouter Wolters voted on patch set 1 V +1 CR +1 02/25/15, 17:03

  3. Markus Klein voted on patch set 1 CR +2 V +2 02/25/15, 17:14

  4. Markus Klein merged patch set 1 02/25/15, 17:14

  5. Tymoteusz Motylewski commented on patch set 2 02/25/15, 17:25

    PreviewHook.php:108

    why did you remove this one?
  6. Markus Klein commented on patch set 2 02/25/15, 17:38

    PreviewHook.php:108 Reply

    search for TYPO3-TT-start in the Core. Completely unused ;-)