37307[TASK] Introduced getters for $GLOBALS in ext:info_pagetsconfig
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Wouter Wolters +1
-
Verified V +2
- Christian Kuhn +2
- Wouter Wolters +1
Issues 1
Files 1
Review log 9
-
Michael Oehlhof uploaded patch set 1 02/26/15, 23:53
-
Michael Oehlhof updated the commit message in patch set 2 02/26/15, 23:54
-
Wouter Wolters commented on patch set 2 02/27/15, 09:24
Maybe a small improvementInfoPageTyposcriptConfigController.php:41Do $lang = $this->getLanguageService(); and use $lang for the rest of the calls?InfoPageTyposcriptConfigController.php:155same here: $beUser = $this->getBackendUser(); -
Michael Oehlhof uploaded patch set 3 02/27/15, 13:19
-
Michael Oehlhof commented on patch set 3 02/27/15, 13:21
Changed according your comments. -
Wouter Wolters voted on patch set 3 CR +1 02/27/15, 13:27
-
Wouter Wolters voted on patch set 3 V +1 02/27/15, 22:07
-
Christian Kuhn voted on patch set 3 CR +2 V +2 03/01/15, 10:25
-
Christian Kuhn merged patch set 3 03/01/15, 10:25