Review main Merged

37569[TASK] Update modernizr to 2.8.3

Benjamin Kott CR +2 V +2 Easy +3 −29 updated 03/06/15, 07:54

Commit message

- Exclude: Media Queries
- Exclude: html5shiv v3.7.1 w/ printshiv

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Stephan Großberndt +1
    • Christian Kuhn +1
  • Verified V +2
    • Wouter Wolters +2
    • Christian Kuhn +1

Issues 1

Files 1

Review log 8

  1. Benjamin Kott uploaded patch set 1 03/05/15, 20:46

  2. Christian Kuhn voted on patch set 1 CR +1 V +1 03/05/15, 20:47

  3. Stephan Großberndt voted on patch set 1 CR +1 03/05/15, 20:48

  4. Wouter Wolters voted on patch set 1 CR +1 03/05/15, 20:49

  5. Wouter Wolters voted on patch set 1 V +2 CR +2 03/05/15, 20:56

  6. Wouter Wolters merged patch set 1 03/05/15, 20:56

  7. Felix Kopp commented on patch set 2 03/06/15, 07:16

    I don't get it exclude shiv but we don't have a bundled shim/shiv yet. Should we not be rather be removing modernizr completely and keep shim/shiv?