Review main Merged

37594[BUGFIX] Install tool image tests broken

Christian Kuhn CR +2 V +2 Normal +32 −54 updated 03/06/15, 13:54

Commit message

Switching the image manipulation from hardcoded cache table to
the caching framework with #28484 triggers a fatal error in
the install tool image tests. This cache was not properly reset
in the install tool initialization.
The patch resolves this by cleaning up the cache initialization
that has been marked as todo since install tool rewrite. This
is solved for now.
The whole situation is still not perfect since bootstrap, install
tool and extensionmanager manipulate this stuff and the static Cache
class with its static properties in front of the caching framework
does not help to encapsulate and separate the different needs. A
further refactoring releasing the system from static dependencies
and direct global access would help here to reduce complexity with
another patch later.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 2

Files 2