Review main Abandoned

37799[BUGFIX] baseURL determination of RTE fails in edge case

Lorenz Ulrich CR 0 V 0 Easy +2 −2 updated 12/21/15, 11:44

Commit message

The RTE has a client-side method of determining the baseURL. The baseURL
is later used for loading additional resources (e.g. custom CSS). It
first tries to use the document.baseURI property (which isn't present in
IE), with fallbacks to the base href in the content and the whole URL.
To ensure that the baseURL is only the path to the TYPO3 installation
(without a document or arguments), a Regex rule is then applied to
extract the path to TYPO3.

This regex rule doesn't match for URLs that have a second full URL in it,
e.g.
http://my.tld/typo3/alt_doc.php?returnUrl=http://my.tld/typo3/foo.php

This leads to a wrong baseURL and prevents resources from being loaded.
This applies if you e.g. open a TCEFORM with an RTE in an iFrame in the
Frontend.

The Regex is improved to work properly also in this edge case.

Review

  • Code review CR 0

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V 0

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 1