Review main Merged

38097[BUGFIX] Check for existing types before binding

Andreas Kienast CR +2 V +2 Easy +9 −7 updated 03/31/15, 18:54

Commit message

Check the $combinedTypes variables if binds actually exist before
calling the bind_param method.

Review

  • Code review CR +2
    • Markus Klein +2
    • Xavier Perseguers +1
    • Cedric Ziel +1
    • Thomas Löffler +1
  • Verified V +2
    • Markus Klein +2
    • Xavier Perseguers +1

Issues 1

Files 1

Review log 7

  1. Andreas Kienast uploaded patch set 1 03/24/15, 10:46

  2. Thomas Löffler voted on patch set 1 CR +1 03/30/15, 07:08

  3. Xavier Perseguers commented on patch set 1 CR +1 V +1 03/30/15, 07:10

    I agree, but would like to remind that the where clause of exec_SELECTgetRows() and similar methods has always been supposed to be given, when none then by convention as "1=1".
  4. Cedric Ziel voted on patch set 1 CR +1 03/31/15, 18:40

  5. Markus Klein voted on patch set 1 CR +2 V +2 03/31/15, 18:53

  6. Markus Klein merged patch set 1 03/31/15, 18:54

  7. Markus Klein commented on patch set 2 03/31/15, 18:54

    Cherry Picked This patchset was cherry picked to branch TYPO3_6-2 as commit 445d35a34dfa365e8bff5c844466cff70492f15e