Review main Abandoned

38411[BUGFIX] Make PATH_INFO work with CGI environments

Benni Mack CR 0 V 0 Easy +12 −0 updated 06/20/15, 11:26

Commit message

Some environments with CGI add a given PATH_INFO
directly to the server variable PATH_TRANSLATED. Currently
TYPO3 does not use PATH_INFO, but mixed setups with
other frameworks on some FastCGI environments do not
work currently.

Example - Call: "/mysite/index.php/my/path/info"
/my/path/info is the last part after the actual script file.
Some environments add this to the PATH_TRANSLATED
variable, but it needs to be stripped away.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 6

  1. Benni Mack uploaded patch set 1 04/01/15, 15:29

  2. Wouter Wolters commented on patch set 1 04/01/15, 15:33

    SystemEnvironmentBuilder.php:310

    calculate 0 - strlen($pathInfo) once and use it twice?
  3. Xavier Perseguers commented on patch set 1 V 0 04/02/15, 06:44

    Well removing my -1, not sure how to test since other routing patch may actually be broken.
  4. Benni Mack uploaded patch set 2 06/16/15, 11:04

  5. Benni Mack abandoned the change 06/20/15, 11:26

    won't work. so I will drop this as long as we do not need PATH_INFO support