Review main Merged

38840[BUGFIX] Multiple fixes for Locking API and TSFE locking

Markus Klein CR +2 V +2 Hard +199 −69 updated 12/10/17, 10:56

Commit message

* Retrieve correct LockingStrategy for requested capabilities
* Prefix lock filenames to make them better visible in the folder
* Make all LockStrategies destroyable
* Semaphore locking now uses ftok() to generate a unique id
* Make the Mbox lock independent of the target file
* Introduce an access lock for each of the TSFE cache locks

We decrease the priority of Semaphore locking since this can
be pretty dangerous for the average user. If something goes
really wrong in the webserver (which is out of our control),
we might leave behind stale semaphores, which might cause
a permanent deadlock for an instance, which can only be resolved
by a server admin.
We might raise the priority again at a later point in time,
when we can provide better means of cleanup.

The new access locks protects the access to the cache locks in TSFE
now, which allows us to safely remove those cache locks after using
them. This way we don't spam the system with loads of locks.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 11