Review main Merged Breaking

39148[!!!][TASK] Refactor property access in compiled fluid templates

Christian Müller CR +2 V +2 Normal +132 −2 updated 05/05/15, 16:17

Commit message

Using ObjectAccess::getPropertyInternal is pretty expensive if called
repeatedly as can happen in bigger templates. On rendering the compiled
template for the first time we can generate the used getter and/or array
access information and write that into the compiled template.
Subsequent usages of the compiled template will then have much faster
access to nested variables.

This change is breaking if you push mixed data to the template. For
example an array that contains both arrays and object and access those
with the same property path access. In this case the cached accessors
might be wrong.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 4