Review main Merged

39462[TASK] FormEngine: Simplify element name resolving

Christian Kuhn CR +2 V +2 Normal +58 −106 updated 05/11/15, 20:30

Commit message

Data submitted by FormEngine to DataHandler is prefixed in four
different ways:
* data - Transferred data
* cmd - A dataHandler command to execute
* data_files - Contains uploaded files
* action[control] - Overwrite fields data for NULL handling

These four prefixes are given along from FormEngine to the
whole container and element structure and never change.

To simplify this stuff, the patch removes the prefixes and
hardcodes them, and introduces a new globalOptions
$elementBaseName that contains the stuff behind the prefixes.
Quite some methods can be simplified this way and become
more obvious. Usage of $elementBaseName will be extended
with the next patch.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 15