Review main Merged

39499Revert "[TASK] Make \Be\Menus\ActionMenuItemViewHelper compilable"

Frank Nägler CR +2 V +2 Normal +13 −53 updated 05/12/15, 14:59

Commit message

This reverts commit 9695759844f2c4981339aff77be50340f8c6b1b6.

Reason for the revert is that initialize() of the abstract is no 
longer called, which takes care of "additionalAttributes" and 
"data-" attributes. The introduced getTagBuilder() method is not 
sufficient. So, basically the rule "no simple migration to compilable 
possible if the VH keeps local state" was violated here.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 2