3960[FEATURE] Group HttpExceptions by Error type
Commit message
Review
-
Code review CR +2
- Steffen Gebert +2
- Stefan Neufeind +1
- Xavier Perseguers +1
- Philipp Gampe +1
-
Verified V +2
- Steffen Gebert +2
- Xavier Perseguers +1
Issues 1
Files 8
- t3lib/error/http/class.t3lib_error_http_abstractclienterrorexception.phpnew+40 −0
- t3lib/error/http/class.t3lib_error_http_abstractservererrorexception.phpnew+40 −0
- t3lib/error/http/class.t3lib_error_http_badrequestexception.php+1 −1
- t3lib/error/http/class.t3lib_error_http_forbiddenexception.php+1 −1
- t3lib/error/http/class.t3lib_error_http_pagenotfoundexception.php+1 −1
- t3lib/error/http/class.t3lib_error_http_serviceunavailableexception.php+1 −1
- t3lib/error/http/class.t3lib_error_http_unauthorizedexception.php+1 −1
- t3lib/core_autoload.php2+2 −0
Review log 9
-
Stefan Neufeind commented on patch set 1 08/02/11, 07:07
Looks good to me, but someone else must approve Errors grouped into client- and server-errors. Quite a small change. Just one more class-inheritance-level inbetween in the hierarchy. -
Xavier Perseguers commented on patch set 1 08/02/11, 07:07
Looks good to me, but someone else must approve -
Xavier Perseguers voted on patch set 1 V 0 08/02/11, 07:07
-
Steffen Gebert commented on patch set 1 08/02/11, 07:07
This is a prerequisite for Ic187d51c -
Steffen Gebert commented on patch set 1 08/02/11, 07:07
(1 inline comment) -
Steffen Gebert commented on patch set 1 V 0 08/02/11, 07:07
by team member; Looks good to me, approved Merging, as the dependence (Ic187d51c) was merged and Gerrit did *not* wait for this one here (after talking to Xavier) -
Philipp Gampe commented on patch set 1 08/02/11, 07:07
Looks good to me, but someone else must approvecore_autoload.php:137do we need autoload for abstract classes? -
Mr. Jenkins commented on patch set 1 08/02/11, 07:07
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/1482/ : SUCCESS -
Steffen Gebert merged patch set 1 08/02/11, 07:07