Review main Merged

3973[BUGFIX] Improve hook in Admin Panel

Georg Ringer CR +2 V +2 Easy +5 −4 updated 06/03/13, 20:49

Commit message

The current implementation is buggy and can be improved.
- Add $moduleContent as argument
- Use '.=' instead of '='

Review

  • Code review CR +2
    • Xavier Perseguers +2
  • Verified V +2
    • Xavier Perseguers +2

Files 2

Review log 13

  1. Xavier Perseguers merged patch set 1 08/14/11, 11:49

  2. Georg Ringer commented on patch set 1 08/14/11, 11:49

    (1 inline comment)
  3. Xavier Perseguers uploaded patch set 3 08/14/11, 11:49

  4. Xavier Perseguers commented on patch set 3 V 0 08/14/11, 11:49

    by team member; Looks good to me, approved Enough review. Just added the missing concatenation as stated in the commit message
  5. Georg Ringer uploaded patch set 2 08/14/11, 11:49

  6. Georg Ringer commented on patch set 3 08/14/11, 11:49

    IMO this is correct as there is no need from other extensions to change additional things which have been added by third party extensions. furthermore menu items from the core can be changed by using tsconfig. if you have some other cases in mind, let us disucss that in dev/core list
  7. Christian Weiske commented on patch set 1 08/14/11, 11:49

    Verified; I would prefer that you didn't submit this Please fix the @param comment, apart from that it's ok.

    interface.tslib_adminPanelHook.php:40

    wrong comment
  8. Christian Weiske commented on patch set 2 08/14/11, 11:49

    Verified; Looks good to me, but someone else must approve
  9. Christian Weiske commented on patch set 3 08/14/11, 11:49

    NO! The concatenation is not needed, since the hooks themselves have to take care about returning everything.
  10. Mr. Jenkins commented on patch set 1 08/14/11, 11:49

  11. Mr. Jenkins commented on patch set 2 08/14/11, 11:49

  12. Mr. Jenkins commented on patch set 3 08/14/11, 11:49

  13. Christian Kuhn commented on patch set 3 08/14/11, 11:49

    Does anyone run the unit tests? This change made the new test fail that was introduced when implementing the hook in the first place :(