Review main Merged

39900[TASK] Clean up DataMapper::convertClassNameToTableName

Mathias Brodala CR +2 V +2 Easy +10 −7 updated 06/11/15, 08:51

Commit message

This removes pointless code which ends up doing strtolower(NULL).

Also make the class name argument mandatory since it does not make
sense to pass nothing or NULL and the core does not do this in any
case.

The latter change makes this mildly breaking if code relies on the
old behavior.

Review

  • Code review CR +2
    • Andreas Kienast +2
    • Wouter Wolters +1
    • Christian Kuhn +1
  • Verified V +2
    • Andreas Kienast +2
    • Christian Kuhn +1

Issues 1

Files 2

Review log 7

  1. Mathias Brodala uploaded patch set 1 06/02/15, 15:29

  2. Mathias Brodala uploaded patch set 2 06/02/15, 15:38

  3. Christian Kuhn voted on patch set 2 CR +1 V +1 06/05/15, 16:17

  4. Wouter Wolters voted on patch set 2 CR +1 06/05/15, 16:24

  5. Andreas Kienast voted on patch set 2 CR +2 06/11/15, 08:36

  6. Andreas Kienast voted on patch set 2 V +2 06/11/15, 08:50

  7. Andreas Kienast merged patch set 2 06/11/15, 08:51