Review main Merged

39972[TASK] Update swiftmailer to 5.4.1

Markus Klein CR +2 V +2 Easy +1 −1 updated 06/07/15, 16:49

Commit message

Review

  • Code review CR +2
    • Helmut Hummel +2
    • Wouter Wolters +1
  • Verified V +2
    • Helmut Hummel +2
    • Wouter Wolters +1

Issues 1

Files 1

Review log 18

  1. Markus Klein uploaded patch set 1 06/05/15, 11:02

  2. Markus Klein uploaded patch set 2 06/05/15, 11:12

  3. Christian Kuhn commented on patch set 2 06/05/15, 11:16

    why a dev dependency?
  4. Mathias Brodala commented on patch set 2 06/05/15, 11:20

    Because the fix was not yet released, see Forge.
  5. Christian Kuhn commented on patch set 2 06/05/15, 11:23

    you're linking to a general change log there. which exact patch to you need so heavily that you consider it a must have blocker that otherwise renders our system unusable? why can't we wait for a proper release?
  6. Markus Klein commented on patch set 2 06/05/15, 11:52

    5.4.1 RFC compliance. Since the last release was in March, I do not expect a release before CMS 7.3 is released. That was my whole intention.
  7. Christian Kuhn commented on patch set 2 CR -1 06/05/15, 12:22

    as far as i can see, only a whitespace after the colon was removed. i guess the majority of smtp servers copes with the current (no bugfix applied) situation. Are there any bug reports in our project regarding this? Again, I would like to refrain from using -dev for for dependencies as long as there are no really good reasons to do that. if this issue is no blocker, i'd to upgrade until there is a release. https://github.com/swiftmailer/swiftmailer/commit/235209f7f805bf7cf665e7b9a4a10042fcc5c969
  8. Markus Klein commented on patch set 2 06/05/15, 12:46

    IMO not conforming to standards/RFCs is a blocker. just say'n
  9. Markus Klein commented on patch set 2 06/06/15, 10:15

  10. Markus Klein uploaded patch set 3 06/06/15, 10:27

  11. Markus Klein commented on patch set 3 CR -2 06/06/15, 10:27

    blocked until 5.4.1 is released
  12. Wouter Wolters voted on patch set 3 V +1 CR +1 06/06/15, 14:31

  13. Markus Klein voted on patch set 3 CR 0 06/06/15, 14:34

  14. Helmut Hummel commented on patch set 3 CR -1 06/07/15, 13:57

    composer.json:39

    we removed all ranges from dependencies for a reason and we should not re-introduce them again.
  15. Wouter Wolters uploaded patch set 4 06/07/15, 15:02

  16. Wouter Wolters voted on patch set 4 V +1 CR +1 06/07/15, 15:02

  17. Helmut Hummel voted on patch set 4 CR +2 V +2 06/07/15, 16:48

  18. Helmut Hummel merged patch set 4 06/07/15, 16:49