Review main Merged

40076[TASK] Remove unnecessary help-block in ReadOnly select

Frank Nägler CR +2 V +2 Easy +1 −2 updated 06/10/15, 09:26

Commit message

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Markus Klein +1
    • Alexander Jahn +1
  • Verified V +2
    • Christian Kuhn +2
    • Markus Klein +1
    • Alexander Jahn +1

Issues 1

Files 1

Review log 8

  1. Frank Nägler uploaded patch set 1 06/08/15, 15:06

  2. Markus Klein voted on patch set 1 CR +1 06/08/15, 15:09

  3. Markus Klein voted on patch set 1 V +1 06/08/15, 15:10

  4. Christian Kuhn commented on patch set 1 06/08/15, 15:15

    misleading wording - we're not talking about type=select here
  5. Christian Kuhn commented on patch set 1 06/08/15, 15:16

    none element is fallback element in several other cases, we should have a look at these.
  6. Alexander Jahn commented on patch set 1 CR +1 V +1 06/09/15, 06:31

    Looks good to me, my issue is fixed. I checked Text/Input/Image element and everything seems to work like it does without the patch. Setting a wizard to hideParent = 1 also works as expected
  7. Christian Kuhn voted on patch set 1 CR +2 V +2 06/10/15, 09:26

  8. Christian Kuhn merged patch set 1 06/10/15, 09:26