Review main Merged

40159[BUGFIX] EM: Use EXEC_TIME for extension export zip filename

Christian Kuhn CR +2 V +2 Easy +6 −3 updated 06/10/15, 21:34

Commit message

Extension export as .zip file uses date() to make file
names "unique". Instead of timestamp "now", $GLOBALS['EXEC_TIME']
is now used as base time stamp since this value
does not change during one call.
The according test is stabilized a bit and additionally sets
$GLOBALS['EXEC_TIME'] to a stable value.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Markus Klein +1
    • Nicole Hummel +1
  • Verified V +2
    • Christian Kuhn +2
    • Markus Klein +1
    • Nicole Hummel +1

Issues 1

Files 2

Review log 7

  1. Christian Kuhn uploaded patch set 1 06/10/15, 21:00

  2. Christian Kuhn commented on patch set 1 06/10/15, 21:02

    this patch was created to stabilize the fail from https://travis-ci.org/TYPO3/TYPO3.CMS/jobs/66256262 which may happen if there is a "leap" in timestamp between file creatino and the assertion.
  3. Christian Kuhn updated the commit message in patch set 2 06/10/15, 21:05

  4. Markus Klein voted on patch set 2 CR +1 V +1 06/10/15, 21:05

  5. Nicole Hummel voted on patch set 2 CR +1 V +1 06/10/15, 21:20

  6. Christian Kuhn voted on patch set 2 CR +2 V +2 06/10/15, 21:33

  7. Christian Kuhn merged patch set 2 06/10/15, 21:34