Review main Merged

40365[BUGFIX] Include doktype in pageOverlayFields

Andreas Wolf CR +2 V +2 Easy +1 −1 updated 06/20/15, 12:14

Commit message

Translation overlays must include the doktype field of the translated
page, to take into account page type changes. Otherwise we get unwanted
behaviour if e.g. the original language is a shortcut, but the
translated page is a standard page. Then still a shortcut will be
rendered, with weird possible mode combinations, rendering the page
unviewable.

This is especially nasty as the translation mode is reset when
translating, making the translated page a "shortcut to selected page"
which is always broken (!) if no page is selected.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 1