Review main Merged

40423[CLEANUP] Code duplication in DataHandler::copyRecord_processManyToMany()

Andreas Wolf CR +2 V +2 Easy +15 −20 updated 06/18/15, 11:01

Commit message

There was a foreach loop that only differed in one line, but was
duplicated due to the complex condition around it. This commit splits
the condition, introduces helper variables and moves the condition
inside the foreach loop to get rid of the duplication.

Additionally, duplicated lines for purging the items of the relation
analyzer are also removed.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 1