Review main Merged

40455[TASK] dbal: skip update suggestions for equivalent fields in Install Tool

Morton Jonuschat CR +2 V +2 Hard +280 −35 updated 07/20/15, 16:55

Commit message

Make the Install Tool / Database Upgrade Wizard ignore database
alterations for functionally equivalent field types / indexes when
used with DBAL. This is required as some special MySQL native fields
like TINYTEXT, TINY- and MEDIUMINT have no matching types and will
get converted by ADOdb to a type that is able to store longer/bigger
values.

This patch makes the SqlSchemaMigrationService check with the DBAL
Driver which field type/index definition will be used and updates
the field type requested by the database compare to reflect the actual
field type for the DBMS.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 5