40518[WIP][BUGFIX] Fix upload of files with utf-8 characters in filename
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 2
Review log 14
-
Daniel Schmidt uploaded patch set 1 06/22/15, 08:23
-
Andreas Kienast updated the commit message in patch set 2 06/22/15, 08:42
-
Andreas Kienast voted on patch set 2 CR +1 06/22/15, 08:42
-
Mathias Brodala commented on patch set 2 CR -1 06/22/15, 08:43
I'll add a test. -
Mathias Brodala uploaded patch set 3 06/22/15, 08:47
-
Mathias Brodala commented on patch set 3 CR -1 06/22/15, 08:48
Added a test but the test already succeeds without the fix. Can someone clarify this? -
Helmut Hummel commented on patch set 3 CR -2 06/22/15, 09:10
Test shows that this change is not needed. I block it here until it is clear up on forge what the exact issue is. -
Oliver Hader uploaded patch set 4 10/09/15, 06:48
-
Daniel Goerz commented on patch set 4 01/10/16, 22:31
I cant reproduce this error but regarding to the ticket it seems to be an edge case. Maybe someone can clearify the matter now, since its been a while since last activity. -
Helmut Hummel commented on patch set 4 03/08/16, 11:05
This may be security relevant. I block this until it is clear that, it will not harm the security of TYPO3 -
Mathias Brodala commented on patch set 4 12/07/16, 14:43
Helmut, could you elaborate on the potential security risk you see here? I think it should be clarified if this is the way to go and brought up to shape or abandoned. -
Helmut Hummel commented on patch set 4 12/08/16, 01:14
First of all, we must avoid to introduce the same issue, which we fixed here: https://review.typo3.org/#/c/50740/2/typo3/sysext/core/Classes/Utility/GeneralUtility.php In this place it would be even more severe, because with /u and invalid utf-8 byte codes, one could upload PHP files as preg_match would return false and we cast this to no matches here. besides that, the check from above might also be not optimal, as it seems to cause issues with latin1 encode filenames that are interpreted as utf-8 string, which makes the regular expression fail as well. so before doing something here, we need to make sure to use all knowledge from the security issue mentioned above and start hardening the code here to not allow files that make the regex fail and then add more test cases from validPathStr to here. Last but not least: I'd rather disallow more files here than taking the risk to allow PHP files to be uploaded. -
Benni Mack abandoned the change 12/09/17, 02:19
No feedback after one year, will abandon the patch for now but leave the ticket open, in case somebody wants to pick it up. -
Oliver Hader commented on patch set 4 10/27/18, 13:51