Review main Merged

40579[TASK] Better description for parameter in AuthenticationService::getGroups()

Frank Nägler CR +2 V +2 Easy +5 −0 updated 06/24/15, 18:55

Commit message

This patch add a note why this parameter should not be removed.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Wouter Wolters +1
  • Verified V +2
    • Christian Kuhn +2
    • Wouter Wolters +1

Issues 1

Files 1

Review log 30

Show 5 earlier messages
  1. Frank Nägler uploaded patch set 1 06/23/15, 21:07

  2. Christian Kuhn voted on patch set 1 V +1 CR +1 06/23/15, 21:17

  3. Wouter Wolters voted on patch set 1 V +1 CR +1 06/23/15, 21:20

  4. Christian Kuhn commented on patch set 1 CR -1 V 0 06/23/15, 21:25

    sysext/frontend/Classes/Authentication/FrontendUserAuthentication.php usese: $serviceObj->getGroups($this->user, $groupDataArr);
  5. Christian Kuhn commented on patch set 1 06/23/15, 21:26

    please don't merge until core usage is adapted ;)
  1. Frank Nägler uploaded patch set 2 06/23/15, 21:32

  2. Frank Nägler commented on patch set 2 06/23/15, 21:32

    fixed the usage
  3. Christian Kuhn voted on patch set 2 CR +1 V +1 06/23/15, 21:33

  4. Frank Nägler voted on patch set 2 CR -2 06/23/15, 21:39

  5. Wouter Wolters commented on patch set 2 V -1 CR -1 06/23/15, 21:44

    this breaks, we should only add a better description why this parameter is there!
  6. Frank Nägler uploaded patch set 3 06/23/15, 22:00

  7. Frank Nägler voted on patch set 3 CR 0 06/23/15, 22:00

  8. Wouter Wolters commented on patch set 3 06/24/15, 06:42

    AuthenticationService.php:124

    phpDoc says: multiline DocComment looks like this /** *
  9. Wouter Wolters uploaded patch set 4 06/24/15, 06:42

  10. Wouter Wolters voted on patch set 4 V +1 CR +1 06/24/15, 06:43

  11. Frederic Gaus commented on patch set 4 06/24/15, 07:13

    AuthenticationService.php:124

    But this is not a phpdoc block, it is a normal comment. In this case /* should be used.
  12. Frank Nägler commented on patch set 4 06/24/15, 07:24

    AuthenticationService.php:124 Reply

    agree with Frederic. Imo we use /** ONLY for docComment above the method, and /* for "normal" multiline comments.
  13. Wouter Wolters voted on patch set 4 V 0 CR 0 06/24/15, 07:28

  14. Oliver Klee commented on patch set 4 06/24/15, 10:23

    AuthenticationService.php:124 Reply

    +1
  15. Christian Kuhn voted on patch set 4 CR +1 V +1 06/24/15, 10:26

  16. Frederic Gaus uploaded patch set 5 06/24/15, 14:51

  17. Frederic Gaus voted on patch set 5 CR +1 V +1 06/24/15, 14:52

  18. Frederic Gaus uploaded patch set 6 06/24/15, 14:58

  19. Frederic Gaus voted on patch set 6 CR +1 V +1 06/24/15, 14:59

  20. Frank Nägler commented on patch set 6 CR -1 06/24/15, 15:12

    AuthenticationService.php:123

    can you please explain this comment? Not sure, but I can't remember that we have used this before in the core.
  21. Frank Nägler uploaded patch set 7 06/24/15, 18:35

  22. Frank Nägler commented on patch set 7 06/24/15, 18:36

    I have removed the annotation, because the annotation is PHPStorm specific and we have no other places in the core, where this kind of comment is used.
  23. Wouter Wolters voted on patch set 7 V +1 CR +1 06/24/15, 18:40

  24. Christian Kuhn voted on patch set 7 V +2 CR +2 06/24/15, 18:55

  25. Christian Kuhn merged patch set 7 06/24/15, 18:55