Review main Merged

40748[BUGFIX] Use single quotes in query for values in EXT:workspaces

Andreas Kienast CR +2 V +2 Easy +1 −1 updated 07/01/15, 10:15

Commit message

Use single quotes for values in the query executed in
WorkspaceService::isOldStyleWorkspaceUsed().

In ANSI SQL, single quotes have to be used for values.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Markus Klein +1
    • Christian Kuhn +1
  • Verified V +2
    • Wouter Wolters +2
    • Markus Klein +1

Issues 1

Files 1

Review log 12

  1. Andreas Kienast uploaded patch set 1 06/30/15, 08:03

  2. David Greiner voted on patch set 1 CR +1 06/30/15, 08:12

  3. Andreas Kienast updated the commit message in patch set 2 06/30/15, 18:37

  4. Wouter Wolters voted on patch set 2 CR +1 06/30/15, 18:38

  5. Markus Klein voted on patch set 2 CR +1 V +1 06/30/15, 18:59

  6. Markus Klein updated the commit message in patch set 3 06/30/15, 18:59

  7. Markus Klein voted on patch set 3 CR +1 V +1 06/30/15, 18:59

  8. Wouter Wolters voted on patch set 3 CR +1 06/30/15, 19:00

  9. Christian Kuhn voted on patch set 3 CR +1 06/30/15, 22:05

  10. Wouter Wolters voted on patch set 3 V +2 CR +2 07/01/15, 10:14

  11. Wouter Wolters merged patch set 3 07/01/15, 10:15

  12. Wouter Wolters commented on patch set 4 07/01/15, 10:15

    Cherry Picked This patchset was cherry picked to branch TYPO3_6-2 as commit 178d0cd7d83a1f73bca2962e194c3e99610b4acc