Review main Merged

41140[BUGFIX] Add Request Handling for Console

Benni Mack CR +2 V +2 Normal +48 −43 updated 07/14/15, 12:39

Commit message

The bootstrap functionality for resolving the RequestHandler
based on the request object added by the PSR-7 change.

The Bootstrap::run() method is now renamed to ->configure()
which does not call resolveRequest() anymore. Instead
resolveRequest() is called explicitly at a later point inside
every Application instance.

This way, the Application instance decides what kind of
Request object should be instantiated and hands it to
the Bootstrap, which in return resolves the RequestHandler.

The original RequestHandlerInterface is now moved to the
Http/ namespace, and a RequestHandlerInterface for the
Console application has been introduced for handling
Console requests, based on Symfony Console.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 15