Review main Merged

41190[BUGFIX] Allow empty upload fields with PSR-7

Benni Mack CR +2 V +2 Easy +44 −4 updated 07/14/15, 16:38

Commit message

When editing a record with a regular file upload field (e.g.
a fe_users record with property image), and one does not choose
to upload a file, the PSR-7 implementation currently restricts
this. The $_FILES array is filled with an empty data set.

Thus, PSR-7 is actually canceling the whole request instead
of letting it bypass, like the DataHandler would do the same
when trying to process the uploaded files later.

The patch allows the PSR-7 implementation only to add
the files that have a filename (tmp_name) given.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 2