Review main Merged

41759[FEATURE] Introduce new Icon API

Frank Nägler CR +2 V +2 Expert +1561 −14 updated 08/06/15, 15:42

Commit message

The logic for working with icons, icon sizes and icon overlays is now bundled into the new IconFactory class.
The new IconFactory will replace the old icon skinning API step by step.

All core icons will be registered directly in the IconRegistry class, third
party extensions must use IconRegistry::registerIcon() to overwrite existing
icons or add additional icons to the IconFactory.

The IconFactory takes care of the correct icon and overlay sizes and the markup.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 22